Reduce dependency on getdkan/contracts (part 1) #4177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-m
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3821
\Contracts\CountableInterface\Countable\Contracts\HydratableInterface\Procrastinator\HydratableInterface\Contracts\ParserInterface\CsvParser\Parser\ParserInterface\Contracts\RetrieverInterfaceand\Contracts\StorerInterfaceremain ingetdkan/contractsbecause there is no clear place to move them. They're needed within multiple libraries. Refactor this in a followup.We also need to keep
getdkan/contractsas a dependency in many places because some libraries useContracts\Mock\Storage\Memoryfor tests. Refactor this in a followup.Our changes to
Drupal\common\Storage\Query... See the @todo which asks if we should just make a QueryInterface.In order to make all these changes, we have to modify the following libraries, maybe in this order.
Each PR is a branch named
no-contracts, some of which have interdependencies on each other. These PRs will need to be updated to require the release of each of these dependencies.getdkan/contractsgetdkan/csv-parsergetdkan/contractsafter PR.getdkan/procrastinatorStorerInterfaceandRetrieverInterface. We need to figure out where to put storage-related interfaces in round 2 of this refactor.getdkan/file-fetcherContracts\Mock\Storage\Memoryfor testing. Refactor in round 2.getdkan/harvestContracts\Mock\Storage\Memoryfor testing. Refactor in round 2.